This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Introduce Arm64 support #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvin-lubecki
force-pushed
the
arm-build
branch
2 times, most recently
from
d67a3f8
to
c2300aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
==========================================
- Coverage 70.4% 70.32% -0.09%
==========================================
Files 67 67
Lines 3740 3740
==========================================
- Hits 2633 2630 -3
- Misses 760 762 +2
- Partials 347 348 +1
Continue to review full report at Codecov.
|
silvin-lubecki
force-pushed
the
arm-build
branch
3 times, most recently
from
91c33db
to
e269dbc
Compare
|
@doanac I'd love your review here 😄 |
ndeloof
approved these changes
Dec 4, 2019
|
Thanks! I hate to be too demanding, but would this be a good time to also do armhf as well? We actually use both aarch64 and armhf in our products. |
|
thanks so much! |
You're welcome 😸 Well, it still needs to pass the CI, but it's just a matter of time. |
Signed-off-by: Nick Adcock <[email protected]>
silvin-lubecki
force-pushed
the
arm-build
branch
from
675aca8
to
d5e7ff7
Compare
…r platforms. Signed-off-by: Silvin Lubecki <[email protected]>
…inux-arm64 platforms. Signed-off-by: Silvin Lubecki <[email protected]>
… docker build. Signed-off-by: Silvin Lubecki <[email protected]>
…invocation image. Signed-off-by: Silvin Lubecki <[email protected]>
silvin-lubecki
force-pushed
the
arm-build
branch
from
d5e7ff7
to
743f7fc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Introduce Arm64 support for docker-app.
- How I did it
docker manifestcommands- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory)
